[webkit-dev] Proposal: Stop EWS bot commenting in bugs
timothy at apple.com
Thu Jan 16 09:41:44 PST 2014
On Jan 16, 2014, at 2:28 AM, Alexey Proskuryakov <ap at webkit.org> wrote:
> 15 янв. 2014 г., в 23:02, Ryosuke Niwa <rniwa at webkit.org> написал(а):
>> I think that it's good to try not dumping build failures into comments right away, and to see what happens.
>> As for not showing style bot failures, it seems almost certain that this will make them substantially more annoying to work with. Can you describe the workflow for patch author and reviewer to deal with style bot warnings when they are not inline? Manually finding relevant lines by number can't work.
>> I agree with Tim that dumping all tested paths along with style warnings is silly. How hard would it be it to get rid of that?
>> The workflow is to click on the bubble to see the style errors. e.g.
> Seems like that would require everyone to manually match errors to code lines indeed, so I object against making this change for style checker warnings.
> - WBR, Alexey Proskuryakov
Yeah, seeing the style warnings as a comment (which also causes them to show up in the patch review) is helpful. I was just complaining about the python path spew it also includes.
— Timothy Hatcher
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the webkit-dev