[webkit-dev] FeatureDefines.h and .xcconfig

[Dean Jackson]

Just answering this bit because the consensus seems to be to go for the single header file.

> On 7 Aug 2014, at 9:57 pm, Laszlo Gombos <laszlo.gombos at webkit.org> wrote:
> 
> > While FeatureDefines.h says "Use this file to list _all_ ENABLE() macros" it also says "The feature defaults in this file are only taken into account if the (port specific) build system has not enabled or disabled a particular feature", which is not true.
> 
> Can you elaborate on why this is not true or perhaps suggest better wording ? Setting any ENABLE_FEATURE_NAME macro to an empty string in xcconfig is explicitly disabling a feature in the build system (see also the comment in e.g. WebCore/Configurations/FeatureDefines.xcconfig)

It doesn't explicitly disable it.

If the .xcconfig says:

ENABLE_FEATURE_NAME=;

Xcode will start a build without that flag defined at all (as an environment variable). Notice that the last line in the .xcconfig is FEATURE_DEFINES = <long list> and the empty string won't provide any data here.

Then FeatureDefines.h comes along and says:

#if !defined(ENABLE_FEATURE_NAME)
#define ENABLE_FEATURE_NAME 1
#endif

Dean


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-dev/attachments/20140808/c74e5ce1/attachment.html>