<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Just answering this bit because the consensus seems to be to go for the single header file.<div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On 7 Aug 2014, at 9:57 pm, Laszlo Gombos <<a href="mailto:laszlo.gombos@webkit.org" class="">laszlo.gombos@webkit.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">> While FeatureDefines.h says "Use this file to list _all_ ENABLE() macros" it also says "The feature defaults in this file are only taken into account if the (port specific) build system has not enabled or disabled a particular feature", which is not true.</div><div style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><br class=""></div><div style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">Can you elaborate on why this is not true or perhaps suggest better wording ? Setting any ENABLE_FEATURE_NAME macro to an empty string in xcconfig is explicitly disabling a feature in the build system (see also the comment in e.g. WebCore/Configurations/FeatureDefines.xcconfig)</div></div></blockquote></div><br class=""></div><div class="">It doesn't explicitly disable it.</div><div class=""><br class=""></div><div class="">If the .xcconfig says:</div><div class=""><br class=""></div><div class="">ENABLE_FEATURE_NAME=;</div><div class=""><br class=""></div><div class="">Xcode will start a build without that flag defined at all (as an environment variable). Notice that the last line in the .xcconfig is FEATURE_DEFINES = <long list> and the empty string won't provide any data here.</div><div class=""><br class=""></div><div class="">Then FeatureDefines.h comes along and says:</div><div class=""><br class=""></div><div class=""><div class="">#if !defined(ENABLE_FEATURE_NAME)</div><div class="">#define ENABLE_FEATURE_NAME 1</div><div class="">#endif</div></div><div class=""><br class=""></div><div class="">Dean</div><div class=""><br class=""></div><div class=""><br class=""></div></body></html>