[webkit-dev] Adding flag to optionally run check-webkit-style as part of prepare-Changelog and svn-create-patch

[James Craig]

On Apr 4, 2014, at 9:08 AM, Zoltan Horvath <zoltan at webkit.org> wrote:

> Hi there,
> 
> prepare-Changelog:
>  - The style checker script runs on the ChangeLogs as well, and it gives warning if the bug number or the tests' line are not filled.

I consider this an expected behavior. If you don't include --bug=12345 parameter when running prepare-Changelog, your diff is currently in a state that would fail style checks. Having the Terminal output immediately tell you that detail is useful.

>  - I think the best behavior for this case would be to abort the change log creation, if there are errors on the actual code check. (Then you can fix those, and when you rerun prepare-Changelog, it puts the recent things into the change log. [e.g. you've got a lower/uppercase function naming warning, and the function name appears in the change log])

I don't think this is right. If we aborted the change log creation, you'd never be able to run prepare-Changelog without the --bug parameter, unless you specifically disabled the style check with --no-style.

> svn-create-patch:
>  - Add it! It's a good idea.
> 
> Cheers,
> <Zoltan>
> 
> 
> 
> On Fri, Apr 4, 2014 at 7:41 AM, James Craig <jcraig at apple.com> wrote:
> Yes, but not everyone uses the webkit-patch script in their workflow.
> 
> > On Apr 4, 2014, at 7:27 AM, Brendan Long <self at brendanlong.com> wrote:
> >
> > Doesn't 'webkit-patch upload' already do that?
> >
> >> On 04/04/2014 02:14 AM, James Craig wrote:
> >> I sometimes forget to run the check-webkit-style script before uploading patches, so I put a patch up for review that adds a --style and --no-style flags to prepare-Changelog and svn-create-patch. Alexey suggested I make it the default, which I've done for prepare-Changelog, but not in svn-create-patch due to cross-references that cause a loop when it't the default. (I just added the --style flag to my local bash alias.)
> >>
> >> Any concerns or suggestions? Thanks.
> >>
> >> http://webkit.org/b/131115
> >>
> >> _______________________________________________
> >> webkit-dev mailing list
> >> webkit-dev at lists.webkit.org
> >> https://lists.webkit.org/mailman/listinfo/webkit-dev
> >
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev
> 
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-dev/attachments/20140404/bbb2187a/attachment.html>