<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>On Apr 4, 2014, at 9:08 AM, Zoltan Horvath <<a href="mailto:zoltan@webkit.org">zoltan@webkit.org</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr">Hi there,<div><br></div><div>prepare-Changelog:</div><div> - The style checker script runs on the ChangeLogs as well, and it gives warning if the bug number or the tests' line are not filled.</div></div></blockquote><div><br></div><div>I consider this an expected behavior. If you don't include --bug=12345 parameter when running prepare-Changelog, your diff is currently in a state that would fail style checks. Having the Terminal output immediately tell you that detail is useful.</div><br><blockquote type="cite"><div dir="ltr"><div> - I think the best behavior for this case would be to abort the change log creation, if there are errors on the actual code check. (Then you can fix those, and when you rerun prepare-Changelog, it puts the recent things into the change log. [e.g. you've got a lower/uppercase function naming warning, and the function name appears in the change log])</div></div></blockquote><div><br></div><div>I don't think this is right. If we aborted the change log creation, you'd never be able to run prepare-Changelog without the --bug parameter, unless you specifically disabled the style check with --no-style.</div><br><blockquote type="cite"><div dir="ltr"><div>svn-create-patch:</div><div> - Add it! It's a good idea.</div><div><br></div><div>Cheers,</div><div><Zoltan></div><div><br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">
On Fri, Apr 4, 2014 at 7:41 AM, James Craig <span dir="ltr"><<a href="mailto:jcraig@apple.com" target="_blank">jcraig@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Yes, but not everyone uses the webkit-patch script in their workflow.<br>
<div class="HOEnZb"><div class="h5"><br>
> On Apr 4, 2014, at 7:27 AM, Brendan Long <<a href="mailto:self@brendanlong.com">self@brendanlong.com</a>> wrote:<br>
><br>
> Doesn't 'webkit-patch upload' already do that?<br>
><br>
>> On 04/04/2014 02:14 AM, James Craig wrote:<br>
>> I sometimes forget to run the check-webkit-style script before uploading patches, so I put a patch up for review that adds a --style and --no-style flags to prepare-Changelog and svn-create-patch. Alexey suggested I make it the default, which I've done for prepare-Changelog, but not in svn-create-patch due to cross-references that cause a loop when it't the default. (I just added the --style flag to my local bash alias.)<br>
>><br>
>> Any concerns or suggestions? Thanks.<br>
>><br>
>> <a href="http://webkit.org/b/131115" target="_blank">http://webkit.org/b/131115</a><br>
>><br>
>> _______________________________________________<br>
>> webkit-dev mailing list<br>
>> <a href="mailto:webkit-dev@lists.webkit.org">webkit-dev@lists.webkit.org</a><br>
>> <a href="https://lists.webkit.org/mailman/listinfo/webkit-dev" target="_blank">https://lists.webkit.org/mailman/listinfo/webkit-dev</a><br>
><br>
_______________________________________________<br>
webkit-dev mailing list<br>
<a href="mailto:webkit-dev@lists.webkit.org">webkit-dev@lists.webkit.org</a><br>
<a href="https://lists.webkit.org/mailman/listinfo/webkit-dev" target="_blank">https://lists.webkit.org/mailman/listinfo/webkit-dev</a><br>
</div></div></blockquote></div><br></div>
_______________________________________________<br>webkit-dev mailing list<br><a href="mailto:webkit-dev@lists.webkit.org">webkit-dev@lists.webkit.org</a><br>https://lists.webkit.org/mailman/listinfo/webkit-dev<br></blockquote></div><br></body></html>