[webkit-dev] Can we disable "control reaches end of non-void function" warning on Qt?

[Myles C. Maxfield]

I can't speak for Qt, but this warning has been helpful for me in the past.


On Thu, Sep 12, 2013 at 2:07 PM, Ryosuke Niwa <rniwa at webkit.org> wrote:

> Hi,
>
> http://trac.webkit.org/changeset/155643 broke Qt build with an error
> saying:
>
> Source/JavaScriptCore/dfg/DFGGPRInfo.h:169:5: error: control reaches end
> of non-void function [-Werror=return-type]
> cc1plus: all warnings being treated as errors
>
> because of the following code:
>
> GPRReg gpr(WhichValueWord which) const
> {
>     switch (which) {
>     case TagWord:
>         return tagGPR();
>     case PayloadWord:
>         return payloadGPR();
>     }
> }
>
> But the code works just fine as is because WhichValueWord only takes two
> values (TagWord and PayloadWord) and they're all handled in the switch
> statement.
>
> Can we disable this warning so that we don't have to add a bogus code like
> the one I had to add in
> http://trac.webkit.org/changeset/155649/trunk/Source/JavaScriptCore/dfg/DFGGPRInfo.h?
>
> - R. Niwa
>
>
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20130912/c60e74af/attachment.html>