[webkit-dev] Moving MemoryInfo under window.internals

[Ryosuke Niwa]

Sounds good to me. Just make sure we don't break performance tests.

- R. Niwa


On Tue, May 28, 2013 at 1:27 PM, Žan Doberšek <zandobersek at gmail.com> wrote:

> Hi,
>
> the MemoryInfo interface[1] is currently exposed in window.console[2] and
> window.performace[3] despite not being standardized or in process of
> standardization by any spec. It's also only partially functional under the
> JSC bindings as the jsHeapSizeLimit attribute returns an undefined value[4].
>
> At the moment grepping through the source tree only shows two uses of the
> interface in a couple of PerformanceTests files[5][6]. Is anyone else aware
> of any other places where it's used downstream (so its removal would break
> things outside of WebKit)?
>
> If possible, I propose moving the interface under window.internals and
> adjust the two places where it's used. This also opens the possibility of
> removing two MemoryInfo-specific settings, memoryInfoEnabled and
> quantizedMemoryInfoEnabled[7]. The quantization[8] of the given memory
> information is also not necessary anymore as the information is not exposed
> to the Web anymore.
> The jsHeapSizeLimit attribute should be removed as well as it's basically
> a no-op with the JSC bindings.
>
> Thoughts?
>
> Cheers,
> Zan
>
> [1]
> http://trac.webkit.org/browser/trunk/Source/WebCore/page/MemoryInfo.idl
> [2] http://trac.webkit.org/browser/trunk/Source/WebCore/page/Console.idl
> [3]
> http://trac.webkit.org/browser/trunk/Source/WebCore/page/Performance.idl
> [4]
> http://trac.webkit.org/browser/trunk/Source/WebCore/bindings/js/JSMemoryInfoCustom.cpp#L39
> [5]
> http://trac.webkit.org/browser/trunk/PerformanceTests/resources/runner.js#L109
> [6]
> http://trac.webkit.org/browser/trunk/PerformanceTests/inspector/performance-test.js#L35
> [7]
> http://trac.webkit.org/browser/trunk/Source/WebCore/page/MemoryInfo.cpp#L143
> [8]
> http://trac.webkit.org/browser/trunk/Source/WebCore/page/MemoryInfo.cpp#L90
>
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20130528/42ec06e2/attachment.html>