[webkit-dev] Moving WebCore/accessibility code into WebCore/platform/
Mario Sanchez Prada
mario.prada at samsung.com
Tue May 21 09:03:24 PDT 2013
> -----Original Message-----
> This is a bad idea. The platform directory has never been intended as
> the single place for all platform-specific code. It's the place for
> platform abstractions that let us cut down on platform-specific code
> elsewhere. It's not a good idea to try to put all platform-specific
> code into the platform directory.
I see. It's true that the accessibility layer is definitely not the same
thing like other ones, such as network or graphics. It's actually more
similar to the render object layer, so I guess you are right.
> > * Besides the AccessibilityObject wrappers and partial platform-
> specific implementation files (e.g. AccessibilityObjectMac.mm) present
> in places like WebCore/accessibility/[atk|mac], there are other bits in
> WebCore/accessibility that are platform specific as well (e.g.
> AccessibilityRenderObject). These bits are guarded with "#if PLATFORM"
> macros, which would still be necessary to meet the different
> requirements of each port.
> There's no problem with this.
> > Of course, we could always add an exception to the style checker
> The style checker rule is wrong and should be removed. It's better to
> use a platform abstraction, but a platform #ifdef is also OK.
What about refining that rule instead of just removing it? Maybe adding a
list of directories to be excluded or something like that might work fine
On this regard, I think it would be specially interesting to hear the
opinion of the people involved in the bug that tracked this addition:
> > but I feel like relocating things would be a better approach in this
> As you can see above, I do not agree.
That's fine. Either removing that rule from the style checker or just
refining it to better match the situation in places such as
WebCore/accessibility will work fine here.
Thanks for the feedback,
More information about the webkit-dev