[webkit-dev] Getting started with making Qt WebKit patches

[Sze Howe Koh]

On 25 March 2013 23:36, Jocelyn Turcotte <jocelyn.turcotte at digia.com> wrote:
> On Mon, Mar 25, 2013 at 12:07:13PM -0300, Rafael Brandao wrote:
>> You're probably missing subversion package. If you're on ubuntu, "sudo
>> apt-get install subversion" should do the trick.

Thanks; installing SVN got rid of the "WindowsError: [Error 2] The
system cannot find the file specified" error.


>> On Mon, Mar 25, 2013 at 12:00 PM, Sze Howe Koh <szehowe.koh at gmail.com>wrote:
>>
>> > Hello,
>> >
>> > I'm trying to submit a patch for Qt WebKit. I've applied the patch to
>> > my local copy of qtwebkit.git, but am having trouble using
>> > webkit-patch. What am I missing?
>
> You might also want to know that qtwebkit.git has a few directories stripped, please use the official git://git.webkit.org/WebKit.git or https://github.com/WebKit/webkit repositories instead.

I only wanted to make a minor documentation patch. Cloning 7.5 GB was
a bit of an overkill :)


>> > I'm running Windows 8 x64, Git version 1.8.0.msysgit.0, and
>> > ActivePython 2.7.2 x64. From Git Bash, I called
>> > `Tools/Scripts/webkit-patch prepare --cc=hausmann at webkit.org'
>
> AFAIK nobody is maintaining webkit-patch on Windows, it currently works much better on Mac and Linux.
> It's also not possible to run tests for QtWebKit on Windows.

I see; that explains the funny errors. In case someone is up for
fixing it, here's another one:

After I installed SVN, I followed the steps to integrate with Git at
http://trac.webkit.org/wiki/UsingGitWithWebKit#Checkout

webkit-patch now gave

    Failed to run "['git', 'merge-base', 'refs/remotes/origin/master',
'HEAD']" exit_code: 123 cwd: c:/Qt/git/5.x.y/qtwebkit
    fatal: Not a valid object name refs/remotes/origin/master


>> > Running Tools/Scripts/prepare-ChangeLog worked ok, but I was under the
>> > impression that webkit-patch is preferred as it automates a lot more
>> > aspects of the workflow (is that correct?)
>
> After running prepare-ChangeLog you can create a bug and upload a patch manually.
> See http://www.webkit.org/coding/contributing.html for more info.

Thanks; submitted (hopefully correctly):
https://bugs.webkit.org/show_bug.cgi?id=113209


Regards,
Sze-Howe