[webkit-dev] Getting started with making Qt WebKit patches

[Jocelyn Turcotte]

On Mon, Mar 25, 2013 at 12:07:13PM -0300, Rafael Brandao wrote:
> You're probably missing subversion package. If you're on ubuntu, "sudo
> apt-get install subversion" should do the trick.
> 
> On Mon, Mar 25, 2013 at 12:00 PM, Sze Howe Koh <szehowe.koh at gmail.com>wrote:
> 
> > Hello,
> >
> > I'm trying to submit a patch for Qt WebKit. I've applied the patch to
> > my local copy of qtwebkit.git, but am having trouble using
> > webkit-patch. What am I missing?

You might also want to know that qtwebkit.git has a few directories stripped, please use the official git://git.webkit.org/WebKit.git or https://github.com/WebKit/webkit repositories instead.

> > I'm running Windows 8 x64, Git version 1.8.0.msysgit.0, and
> > ActivePython 2.7.2 x64. From Git Bash, I called
> > `Tools/Scripts/webkit-patch prepare --cc=hausmann at webkit.org'

AFAIK nobody is maintaining webkit-patch on Windows, it currently works much better on Mac and Linux.
It's also not possible to run tests for QtWebKit on Windows.

> > Running Tools/Scripts/prepare-ChangeLog worked ok, but I was under the
> > impression that webkit-patch is preferred as it automates a lot more
> > aspects of the workflow (is that correct?)

After running prepare-ChangeLog you can create a bug and upload a patch manually.
See http://www.webkit.org/coding/contributing.html for more info.

Cheers,
Jocelyn

p.s. For QtWebKit-specific questions https://lists.webkit.org/mailman/listinfo/webkit-qt is a better place to ask.