[webkit-dev] Compiling WebKit up to 25% faster in Windows?

[Ryosuke Niwa]

On Tue, Mar 26, 2013 at 4:35 PM, Daniel Bratell <bratell at opera.com> wrote:

> Den 2013-03-26 21:29:32 skrev Benjamin Poulain <benjamin at webkit.org>:
>
>
>  On Tue, Mar 26, 2013 at 1:20 PM, Dirk Pranke <dpranke at chromium.org> wrote
>>
>>>
>>> If we have consensus that we should just switch to paths relative to
>>> Source (or maybe a couple different options), that would be (IMO) a big
>>> win. It sounds like Daniel & co. have already done the big bang
>>> conversion.
>>>
>>>
>> I think using full path would be a serious hit regarding hackability.
>>
>> I would rather spend some time tweaking my compiler to cache each
>> directory
>> content than waste time finding where is every single header I need to
>> include.
>>
>
> I guess you mean that it will be more job moving files around, but that is
> a rather rare operation, while reading an include directive and wondering
> what it's part of is rather common (both for compilers, tools and humans).
>
> I like the paths as a tool to indicate "module" dependencies. You can more
> easily see that a file depends on foo and bar (but not on fie) if you see:
>
> #include "foo/object.h"
> #include "foo/thing.h"
> #include "bar/stuff.h"
>
> That will tell you useful things, and avoid making layering violations by
> accident.
>

Sure, but we don't really have multiple modules/components inside WebCore.
I can definitely see being able to spot this across different projects in
Source (e.g. between WTF, JSC, WebCore, & WebKit) but we already do this so
I'm not sure what kind of layering violations this is going to help us
detect.  Do you have a specific use case in mind where this would have
helped us?

I can see that this would be helpful in separating WebCore and Platform
(currently misplaced in WebCore/platform/) but we don't have many
self-contained components like Platform in WebCore.

It's also worth noting that we can't easily use relative file paths to
specify headers across WTF, JSC, WebCore, WebKit, etc.. due to build system
constriants.

- R. Niwa
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20130326/af474acf/attachment.html>