[webkit-dev] Spelling document markers: Design question

Hajime Morrita morrita at chromium.org
Sun Mar 10 22:40:24 PDT 2013

There are DocumentMarker, or DocumentMakerDetails. Which do you have in
your mind?

For me, it seems DocumentMarker is the right place to put such an ID since
DocumentMarkerDetails is an immutable, shared object and giving such ID
breaks the assumption for instance sharing.

Or you can possibly introduce another DocumentMakerDetails for the
"contextual  marker". This approach might be cleaner. By introducing the
new subclass, it won't interfere existing marker implementations. One
caveat of this approach is that this needs extra heap allocations since
DocumentMarkerDetails with unique IDs cannot be shared and will be
allocated per marker.

Sorry for my slow response. Hope this helps.

On Fri, Mar 8, 2013 at 7:58 AM, Rouslan Solomakhin <
rouslan+webkit at chromium.org> wrote:

> Howdy folks,
> The contextual spellcheck in Chromium needs to identify the spellcheck
> request that added spelling markers to the document. This information will
> be used to provide a feedback loop to the contextial spellcheck. I was
> thinking about adding an ID field to DocumentMarkerDescription detail. Is
> this a correct approach?
> Thank you all for thoughts and suggestions!
> Cheers,
> Rouslan
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20130311/1a5973fb/attachment.html>

More information about the webkit-dev mailing list