[webkit-dev] Exporting symbols (was Re: Common build system (was Re: WebKit Wishes))

[Ryosuke Niwa]

On Thu, Jan 31, 2013 at 5:20 PM, Hajime Morrita <morrita at chromium.org>wrote:

> The history aside, I think it makes sense to use the export macro
> specifically for Mac WebCore because
>
> - As Eric mentioned, Currently only Mac and Win WebCore do WebCore/WebKit
> separation.
>   Other ports like GTK or Chromium build single "WebKit" library which has
> both WebCore and WebKit API included.
>   So we need to care about only Mac and Win for now.
>
> - Mac WebKit has relatively comprehensive feature set. It covers most of
> possibly exported symbols.
>
> - The Windows toolchain allows us to use both export symbols list and
> source-level annotation (the macro).
>   Thus on Windows, we could use the Mac-centered export macro *and* an
> export symbol list which covers Win-specific exports.
>
>   This means that there are unused exports on Win build, but I believe it
> is very few considering that Mac/Win ports has
>   similar feature set, which targets Safari on each platform. (This might
> be wrong assumption though - On Mac, there are
>   many other WebKit embedder other than Safari.)
>
> One exception is symbols exported for WebCoreTesting.
> Fortunately, these symbols are exactly same across ports and we can use
> another macro like
> WEBCORE_TESTING_EXPORT for that.
>

Doesn't GTK+ port also require symbol exports for WebKit2? In particular, I
thought all symbols used in Internals need to be exported there.

- R. Niwa
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20130131/28bdad5a/attachment.html>