[webkit-dev] Int/FloatPoint and Int/FloatSize

Simon Fraser simon.fraser at apple.com
Wed Jan 9 17:40:57 PST 2013

On Jan 9, 2013, at 4:52 PM, Steve Block <steveblock at chromium.org> wrote:

>> I'm really not sure that this set of changes is going in the right direction. What's driving them; some abstract sense of purity, or
>> reducing the chances of introducing real bugs that we've seen in the past?
> Some of both. I was investigating a bug where WebCore is generating
> unexpected negative sizes. While looking into how this could happen, I
> noticed that in some cases, negative sizes result from size types
> being used to represent things that seem more like points. It seems
> like it would be good to clean this up this misuse of size types, and
> perhaps in the long term, we can avoid negative sizes altogether,
> which would help avoid these kinds of bug in the future.

It seems like a lot of churn for relatively little gain. I'd rather our time be focused
on areas that actually benefit users of WebKit.


More information about the webkit-dev mailing list