[webkit-dev] Best practices for landing new/changed layout test expectations?
glenn at skynav.com
Mon Feb 25 17:38:29 PST 2013
On Mon, Feb 25, 2013 at 6:17 PM, Ryosuke Niwa <rniwa at webkit.org> wrote:
> On Mon, Feb 25, 2013 at 5:06 PM, Glenn Adams <glenn at skynav.com> wrote:
>> On Mon, Feb 25, 2013 at 5:27 PM, Ryosuke Niwa <rniwa at webkit.org> wrote:
>>> Quite frankly, I don't want it to be my (or anyone but patch author's)
>>> job to take care of all these stale entries people add.
>> I agree, but I think that sloppy follow-up doesn't mean the approach is
>> necessarily bad. We have to police our own work and others all the time.
> If we need to constantly remind people to do X, then X needs to be removed
> from the list of things we need to remember to do.
Or, we need to automate it in the process, like having style bot serve as a
gatekeeper for people that forget to run check-webkit-style on their own.
I'm sure that most of us have forgotten to run it ourselves, but that
doesn't mean we should remove the tool or the style bot.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the webkit-dev