[webkit-dev] ChangeLog format

Ryosuke Niwa rniwa at webkit.org
Wed Aug 21 14:25:18 PDT 2013


On Wed, Aug 21, 2013 at 2:04 PM, Ryosuke Niwa <rniwa at webkit.org> wrote:

> Hi,
>
> I have noticed that the change log format has recently been changed.
>  Unfortunately, this didn't work well with all webkitpy tools we have, and
> has been rolled out in http://trac.webkit.org/changeset/154406.
>
> *I kindly ask you to manually edit your patch to use the old format
> before landing your patch for now.*
>

To clarify, the old multi-line format looks like:

2013-08-13  Ryosuke Niwa  <rniwa at webkit.org>

        REGRESSION(r150187): Safari fails to render allrecipe.com comment
popups
        https://bugs.webkit.org/show_bug.cgi?id=119780

        Reviewed by Benjamin Poulain.

while new single-line format looked like:

2013-08-18  Ryosuke Niwa  <rniwa at webkit.org>

        <https://webkit.org/b/119917> Pasting multiple lines into a
textarea can introduce extra new lines

        Reviewed by Darin Adler.

Separately, I'd like to know whether people liked the new format and it's
> worth my time making webkitpy adopt the new format.
>
> I personally didn't like the *new single-line* format because it made the
> first line of each change log too long.  I'm also not a big fun of wrapping
> URLs in angle brackets.  It's also unclear to me what should happen when
> there are multiple Bugzilla URLs to list.
>
> But I hear the new format made git log --oneline much more readable so I
> can be convinced although I don't intend to use git for WebKit development
> in the foreseeable future myself.
>
> - R. Niwa
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20130821/3a7ca5c0/attachment.html>


More information about the webkit-dev mailing list