[webkit-dev] Proposal: Remove Pointer Lock API

[Andreas Kling]

That sounds great! The sooner we get it enabled on the GTK bot the better. :)

Please not that I am not passing judgement on the feature, it’s just that having #ifdef’ed code that isn’t actively built by bots is bad for codebase health.

-Kling

On Aug 19, 2013, at 10:27 AM, Simon Pena Placer <simon.pena at samsung.com> wrote:

> Hi Andreas,
>  
> As Gyuyoung Kim says, in GTK we are trying to have it enabled quite soon.
>  
> The patch at [1] is already working: I used the Pointer Lock example at ThreeJS[2] to try it, and although there are still some open issues, they shouldn’t be a problem. A more complex example, the Quake 3 map explorer at [3], doesn’t work, but it is related to a different JSC issue.
>  
> This feature is part of the WebKit2GTK+ Roadmap [4], so there is an existing plan to ship it.
>  
> Best regards,
>  
> Simon
> [1] https://bugs.webkit.org/show_bug.cgi?id=99036
> [2] http://threejs.org/examples/misc_controls_pointerlock.html
> [3] http://media.tojicode.com/q3bsp/
> [4] http://trac.webkit.org/wiki/WebKitGTK/WebKit2Roadmap
>  
> From: webkit-dev-bounces at lists.webkit.org [mailto:webkit-dev-bounces at lists.webkit.org] On Behalf Of Gyuyoung Kim
> Sent: 18 August 2013 03:38
> To: Andreas Kling
> Cc: WebKit Development
> Subject: Re: [webkit-dev] Proposal: Remove Pointer Lock API
>  
> Hi Andreas,
>  
> EFL port has not supported it yet. So, I think we don't mind to remove it. However, it looks GTK port wants to enable it on Bug 99036.
>  
> Bug 99036 - [GTK] Enable Pointer Lock feature
> (https://bugs.webkit.org/show_bug.cgi?id=99036)
>  
> Gyuyoung.
>  
>  
>  
> 
> On Sun, Aug 18, 2013 at 4:41 AM, Andreas Kling <akling at apple.com> wrote:
> Hi WebKittens,
> 
> I’d like to propose removing the Pointer Lock API code from WebKit. The code hasn’t been touched for 12 months, and AFAICT no ports are building with ENABLE(POINTER_LOCK).
> 
> Is anyone currently building (and shipping / planning to ship) this API?
> 
> Other thoughts?
> 
> -Kling
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20130819/12cf122f/attachment.html>