[webkit-dev] mouseenter and mouseleave events

[Allan Sandfeld Jensen]

On Tuesday 16 April 2013, you wrote:
> Hi
> 
> On Tue, Apr 16, 2013 at 5:08 AM, Allan Sandfeld Jensen 
<kde at carewolf.com>wrote:
> > I have recently uploaded a new patch to
> > https://bugs.webkit.org/show_bug.cgi?id=18930 to implement mouseenter and
> > mouseleave events.
> 
> This sounds nice, but shouldn't you finish the support for image-rendering
> first?
> You added the code but it is not enabled anywhere. There is not one test
> covering the feature.
> 
That is because it is not meant to be enabled any time soon. The CSS4 
definitions are only there to guide our implementation so it behaves in a 
forward compatible way. The problem is we enabled a small part of image-
rendering back when it was a proposal for CSS3 (and because it is part of SVG 
CSS). The standardization effort is in CSS4 and will probably take a few years 
before it is ready to be enabled on any ports.

Testing that animations are now in high quality when using the SVG CSS image-
rendering: optimizeQuality, is unfortunately not possible with our existing 
layout tests. I could add a manual test though, if you think that is better. I 
also have a patch to add the rest of the ifdefs for the feature so the related 
code is more easy to localize, but I don't like adding the feature to the 
build systems since it shouldn't really be enabled.

Not that I am going to defend the CSS4 parts being in the tree that hard. Now 
that I revisit the idea, I am less sure it was a good idea. It just seemed 
better than correcting an unstandardised feature without a guideline.

Best regards.
`Allan