[webkit-dev] ScrollableArea::scrollSize() vs ScrollableArea::maximumScrollPosition()
simon.fraser at apple.com
Mon Apr 1 15:14:17 PDT 2013
On Apr 1, 2013, at 2:47 PM, Xianzhu Wang <wangxianzhu at chromium.org> wrote:
> ScrollableArea::scrollSize() and ScrollableArea::maximumScrollPosition() seem to return the same value if the parameters of the scrollbars are updated. Can we remove one of them?
I don't understand the " if the parameters of the scrollbars are updated" part.
Do they return the same thing if scrollOrigin is not 0,0? This happens in RTL contexts.
> I think the benefits are:
> - no redundancy;
> - ScrollableArea could be independent on scrollbars;
> - maximumScrollPosition() is more up-to-date without the need of updateScrollbars;
> - the ambiguity of the name scrollSize (e.g. RenderLayer::m_scrollSize and RenderLayer::scrollSize() are totally different things) can be eliminated
> What do you think? Am I missing anything?
More information about the webkit-dev