[webkit-dev] Is there a rule to use UNUSED_PARAM ?

[noam.rosenthal at nokia.com]

How about ASSERT_USING and ASSERT_WITH_MESSAGE_USING?
If we use a variable in an assert it's no longer unused…

e.g. ASSERT_USING(timer, timer == &m_resumeTimer);

On Oct 1, 2012, at 6:17 PM, ext Mike Lawther <mikelawther at google.com<mailto:mikelawther at google.com>> wrote:

ASSERT_WITH_OTHERWISE_UNUSED.


On 2 October 2012 10:51, Ryosuke Niwa <rniwa at webkit.org<mailto:rniwa at webkit.org>> wrote:
How about ASSERT_OR_UNUSED or ASSERT_USING_UNUSED?

On Mon, Oct 1, 2012 at 5:23 PM, Darin Adler <darin at apple.com<mailto:darin at apple.com>> wrote:
On Oct 1, 2012, at 5:21 PM, Mike Lawther <mikelawther at google.com<mailto:mikelawther at google.com>> wrote:

> my first reading of that name had me thinking it meant 'ASSERT that this variable is unused' in the vein of macros I've seen in other places like ASSERT_TRUE, ASSERT_NOT_NULL etc.

Yes, even though I named the macro I have had the same thought often. I love the macro, but a better name, even if a bit longer, would be welcome. If we can think of one we can fix this with a quick global replace.

-- Darin
_______________________________________________
webkit-dev mailing list
webkit-dev at lists.webkit.org<mailto:webkit-dev at lists.webkit.org>
http://lists.webkit.org/mailman/listinfo/webkit-dev


_______________________________________________
webkit-dev mailing list
webkit-dev at lists.webkit.org<mailto:webkit-dev at lists.webkit.org>
http://lists.webkit.org/mailman/listinfo/webkit-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20121002/7264358e/attachment.html>