[webkit-dev] r- your own patches [was: Re: RenderArena: Teaching an old dog new tricks]

Yong Li yong.li.webkit at gmail.com
Fri Nov 16 13:54:40 PST 2012

2012/11/16 Julien Chaffraix <julien.chaffraix at gmail.com>:
>> Seconded. I also think only the one who submitted the patch can clear
>> the r? flag. Others should NOT do that, please, even you are a
>> reviewer. You can r- the patch if you believe it is bad.
> I disagree with that. You seem to think that patches falls into either
> good or bad. However the reality is more complex and there are levels
> of goodness and badness. I use r- for patches that I really think are
> not in the right direction or shouldn't be landed: it is a statement

True. I was inaccurate in that statement.

> Clearing the flag is for patches that are close
> enough but still not up to our standards and that I want to kick off
> the review queue.

In this case you should still r- it.

More information about the webkit-dev mailing list