[webkit-dev] A massive rebaseline needed for r117672

Dumez, Christophe christophe.dumez at intel.com
Sat May 19 05:00:54 PDT 2012


Hi,

I took care of the rebaseline for EFL port at:
https://bugs.webkit.org/show_bug.cgi?id=86940

I just need a committer to cq+.

Kr,

On Sat, May 19, 2012 at 12:33 PM, Ryosuke Niwa <rniwa at webkit.org> wrote:

> I've rebaselined tests in:
> http://trac.webkit.org/changeset/117673
> http://trac.webkit.org/changeset/117674
> http://trac.webkit.org/changeset/117676 (philn)
> http://trac.webkit.org/changeset/117677
> http://trac.webkit.org/changeset/117679
> http://trac.webkit.org/changeset/117681 (ossy)
> http://trac.webkit.org/changeset/117682
> http://trac.webkit.org/changeset/117686
>
> Special thanks to philn and ossy who rebaselined tests for GTK and Qt
> respectively.
>
> Unfortunately, I was not able to rebaseline tests for Windows and EFL bots
> because Windows bots have been failing to compile since r117672 and EFL
> bots don't seem to upload results properly (I can't see diff on results
> page).
>
> - Ryosuke
>
> On Fri, May 18, 2012 at 9:51 PM, Ryosuke Niwa <rniwa at webkit.org> wrote:
>
>> Hi,
>>
>> I just landed r117672 <http://trac.webkit.org/changeset/117672> to fix
>> padding issues with input elements; namely it removed 1px left and right
>> paddings inside input elements. Unfortunately, this change requires
>> rebaselines of roughly 150 pixel tests (Mac and Chromium Mac rebaselines
>> are done in http://trac.webkit.org/changeset/117673 and
>> http://trac.webkit.org/changeset/117674).
>>
>> In many tests, contents in input element are shifted to the start (left
>> in LTR and right in RTL) by 1px, and widths of input elements are shrunk by
>> 2px.
>>
>> I intend on doing most of rebaselines myself but I can't be perfect so I
>> apologize for any inconveniences it may cause in advance.
>>
>> Best,
>> Ryosuke Niwa
>> Software Engineer
>> Google Inc.
>>
>>
>
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
>


-- 
Christophe Dumez
Linux Software Engineer, PhD
Intel Finland Oy - Open Source Technology Center
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20120519/c04ecf5c/attachment.html>


More information about the webkit-dev mailing list