[webkit-dev] Simplifying syntax in test_expectations.txt (bug 86691)

Maciej Stachowiak mjs at apple.com
Thu May 17 16:29:56 PDT 2012


On May 17, 2012, at 1:42 PM, Ojan Vafai <ojan at chromium.org> wrote:

> On Thu, May 17, 2012 at 1:37 PM, Peter Kasting <pkasting at chromium.org> wrote:
> On Thu, May 17, 2012 at 1:34 PM, Ojan Vafai <ojan at chromium.org> wrote:
> 2. Make outcomes optional. If they are left out, then the test is skipped (unless the test is marked SLOW, in which case it's expected to pass). There is no SKIP modifier.
> 
> I don't think we should do this.  It seems very subtle.  I'd rather be explicit.
> 
> I'm OK with the rest of your numbered proposals.
> 
> I disagree, but I'm fine with punting this to the list of controversial changes that we should discuss separately. FWIW, my main motivation here is that it allows us to unify the Skipped file format with the test_expectations.txt format. But again, we can discuss that separately.

Adding SKIP (or whatever) to every line of skipped files is not a big hurdle, I think we could live with that is a transitions tep. I think the bigger hurdle is supporting chaining across multiple directories.

 - Maciej

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20120517/156e711e/attachment.html>


More information about the webkit-dev mailing list