[webkit-dev] Simplifying syntax in test_expectations.txt (bug 86691)

Ryosuke Niwa rniwa at webkit.org
Wed May 16 21:08:40 PDT 2012


There has been some complaints / discussions about how syntax in
test_expectations.txt is confusing (and I agree with you) on webkit-dev and
at contributors' meeting.

So I have a patch on https://bugs.webkit.org/show_bug.cgi?id=86691 to
simplify syntax in test_expectation.txt as follows:

   - Bug modififers are bug numebr themselves for WebKit and URLs for
   non-WebKit bugs
   e.g. 12345 and crbug.com/12345 instead of BUGWK12345 and
   - : and = delimiters are no longer needed
   - All modifiers and expectations show before test name
   e.g. 12345 WIN MAC TEXT IMAGE test.html instead of BUGWK12345 WIN MAC :
   test.html = TEXT IMAGE

Just listing a test DOES NOT automatically skip a test even after my patch
is applied:
will result in a warning, and we still expect it to pass. I'll cite Ojan's
comment for the rationale:

> The bigger problem with implying SKIP, is how do you decide when SKIP
> isn't applied? That needs some hidden set of rules that's too complicated
> IMO.

We can come back to this problem later if we wanted but let us start from
the above cleanups first.

For those who are interested, we're also going to rename
test_expectations.txt to something more WebKitty on

Best regards,
Ryosuke Niwa
Software Engineer
Google Inc.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20120516/4bcf0c0a/attachment.html>

More information about the webkit-dev mailing list