[webkit-dev] Unit Test for Page Breaks / absolute coordinates in PrintContext::pageNumberForElement

[Milian Wolff]

On Thursday 29 March 2012 11:23:57 Ryosuke Niwa wrote:
> On Thu, Mar 29, 2012 at 6:23 AM, Milian Wolff <milian.wolff at kdab.com> wrote:
> > I'm trying to write a unit test for my layouting patch, that prevents page
> > breaks in table rows.
> 
> You mean layout tests / regression tests? We don't normally write C++ unit
> tests for these things.

Right, I mean layout test and it's written in javascript/html yet I still need 
to figure out whether a page break occurred in a table row. Hence the C++ code 
requirement.

> > So far, I've extended the layoutTestController with
> > a pageBreaksInElementById function, similar to pageNumberForElementById.
> 
> Since you seem to be only testing WebCore rendering code and not WebKit
> code, it's better to add methods to internals. (See WebCore/testing).

thanks, I'll take a look at that.

> Do you have a bug for this? Or you're not planning to contribute your
> change to WebKit repository?

Yes, see: https://bugs.webkit.org/show_bug.cgi?id=82617

bye
-- 
Milian Wolff | milian.wolff at kdab.com | Software Engineer
KDAB (Deutschland) GmbH&Co KG, a KDAB Group company
Tel. Germany +49-30-521325470, Sweden (HQ) +46-563-540090
KDAB - Qt Experts - Platform-independent software solutions
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 3631 bytes
Desc: not available
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20120330/5be9ec5c/attachment.bin>