[webkit-dev] CSS3 Selectors3 test suite

Emil A Eklund eae at chromium.org
Thu Mar 22 19:25:07 PDT 2012

On Thu, Mar 22, 2012 at 18:41, Ojan Vafai <ojan at chromium.org> wrote:
> I've recently been greening Chromium's expectations for css3/selectors3.
> ~10% of these test need interaction (e.g. hovering over a link or selecting
> text). Given that this is an imported test suite does it make sense to add
> the appropriate layoutTestController hooks? As it is, the tests aren't
> really verifying correctness.

Seems like a good idea.

> Also, this test suite is a great example of one that I think it would make
> more sense for us to check in reftest expected results instead of
> png+rendertreedump. These tests are explicitly testing selector matching
> only, so it would be easy to write reftests that have a high confidence of
> accurately verifying correctness. They'd only fail if we had some egregious
> bug such that we painted everything green as white. Presumably we'd notice
> such a bug through other means.

Again, I think that would be valuable (and lead to way fewer incorrect
failures and thus lowering the maintenance costs over time). As such
I'd gladly help with the conversion work if we do end up going down
that route.


More information about the webkit-dev mailing list