[webkit-dev] Windows build issue with r110420

[M Rahaman]

Hi All,

 

I just noticed that in the latest revision r110541, these errors are fixed
in the same way discussed below. So, someone must have fixed this in later
revision. Sorry for spamming L

Regs,

Rahaman

 

From: M Rahaman [mailto:mrahaman at innominds.com] 
Sent: Tuesday, March 13, 2012 11:54 AM
To: webkit-dev at lists.webkit.org
Subject: Windows build issue with r110420

 

Hi All,

I am facing Windows build issue with r110420 for some files, the errors are
as mentioned below

 

\RenderThemeSafari.cpp(43) : fatal error C1083: Cannot open include file:
'RetainPtr.h': 

source\webcore\platform\graphics\win\UniscribeController.h(32) : fatal error
C1083: Cannot open include file: 'Vector.h':

 

I found that these are WTF headers & are present inside
./Debug/include/private/JavaScriptCore/wtf/RetainPtr.h

 

In all the files, where the problem is reported are including the header
files as "RetainPtr.h" where from the above include path, it should be
"wtf/RetainPtr.h" => this is how in most of the files the header file is
included. Therefore, I think this is a valid issue. If anyone can please
comment on this, I can submit a patch for this. BTW, after changing the
include file as mentioned, my build went through.

 

Regs,

Rahaman

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20120313/c454f7d8/attachment.html>