[webkit-dev] Is converting pixel tests to reftests kosher for imported libraries?

[Darin Fisher]

Hrm, if the test expectations are customized already for different ports of
WebKit, then why not support replacing a PNG file with a HTML file that is
intended to generate exactly the same result?  How does this impair our
ability to update the tests?

(I realize that our current reftest system may not work like this.  I'm not
familiar with the details of how it works in fact, but it seems like it
could be as simple as having an expected result that is a HTML file instead
of a PNG file.)

-Darin


On Wed, Mar 7, 2012 at 4:10 PM, Maciej Stachowiak <mjs at apple.com> wrote:

>
> I'd prefer we not modify imported test suites. That will just make it more
> confusing to update. Perhaps future CSS test suites will be changed to a
> reftest model.
>
> Regards,
> Maciej
>
> On Mar 7, 2012, at 1:41 PM, Ojan Vafai wrote:
>
> I just did a first pass a greening the Chromium Lion bot:
> http://trac.webkit.org/changeset/110096. Of these hundreds of tests,
>  ~99% of them are perfect candidates for being reftests (e.g. they contain
> one line of text and a solid box or two under the text), but most of them
> are in the CSS imported test suites.
>
> Is it kosher to convert them to reftests or should we leave pixel tests
> from imported test suites alone?
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
>
>
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20120307/2f859f85/attachment.html>