[webkit-dev] Is converting pixel tests to reftests kosher for imported libraries?

Maciej Stachowiak mjs at apple.com
Wed Mar 7 16:10:47 PST 2012

I'd prefer we not modify imported test suites. That will just make it more confusing to update. Perhaps future CSS test suites will be changed to a reftest model.


On Mar 7, 2012, at 1:41 PM, Ojan Vafai wrote:

> I just did a first pass a greening the Chromium Lion bot: http://trac.webkit.org/changeset/110096. Of these hundreds of tests,  ~99% of them are perfect candidates for being reftests (e.g. they contain one line of text and a solid box or two under the text), but most of them are in the CSS imported test suites.
> Is it kosher to convert them to reftests or should we leave pixel tests from imported test suites alone?
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20120307/6749f031/attachment.html>

More information about the webkit-dev mailing list