[webkit-dev] WTF_Please_use_ASCIICType_... and system header includes (on QNX)

[Milian Wolff]

Hey all,

I'm currently trying to patch (Qt-)WebKit in order to build it for QNX. Now 
I'm running into an issue which I wonder how to address properly. Most *.cpp 
files start with the following lines in WebKit:

// file foo.cpp:
#include "config.h"
#include "foo.h"

Now, this might trigger the inclusion of system headers from QNX eventually. 
If these contain stuff like e.g.:

		// FUNCTION _Tolower
inline int _Tolower(int _Byte, const _Ctypevec *)
	{	// perform locale-specific tolower
	return (_CSTD tolower(_Byte & 0xff));
	}

you get a compile time error: 
'tolower_WTF_Please_use_ASCIICType_instead_of_ctype_see_comment_in_ASCIICType_h' 
is not a member of 'std'

I see how this is useful for WebKit code, but it should not be triggered for 
system includes or third-party includes, should it? Does anyone have an idea 
on how I could solve this?

For now I'll work-around this issue by disabling DisallowCType.h on QNX, but I 
whether anyone has a better idea.

Cheers

PS: Here's a full error trace that shows how we end up at the function 
_Tolower I quoted above:

~~~~~~~~~~~~~~~~
In file included from 
/home/milian/bbndk-2.0.1/target/qnx6/usr/include/cpp/xlocale:12,
                 from 
/home/milian/bbndk-2.0.1/target/qnx6/usr/include/cpp/xiosbase:7,
                 from 
/home/milian/bbndk-2.0.1/target/qnx6/usr/include/cpp/streambuf:7,
                 from 
/home/milian/bbndk-2.0.1/target/qnx6/usr/include/cpp/xlocnum:10,
                 from 
/home/milian/bbndk-2.0.1/target/qnx6/usr/include/cpp/ios:7,
                 from 
/home/milian/bbndk-2.0.1/target/qnx6/usr/include/cpp/ostream:7,
                 from 
/home/milian/bbndk-2.0.1/target/qnx6/usr/include/cpp/istream:7,
                 from 
/home/milian/bbndk-2.0.1/target/qnx6/usr/include/cpp/string:7,
                 from /home/milian/projects/qt5/install-
playbook/include/QtCore/qstring.h:50,
                 from /home/milian/projects/qt5/install-
playbook/include/QtCore/qobject.h:48,
                 from /home/milian/projects/qt5/install-
playbook/include/QtCore/qiodevice.h:46,
                 from /home/milian/projects/qt5/install-
playbook/include/QtCore/qdatastream.h:46,
                 from /home/milian/projects/qt5/install-
playbook/include/QtCore/QDataStream:1,
                 from 
/home/milian/projects/qt5/qtwebkit/Source/WTF/wtf/Vector.h:35,
                 from 
/home/milian/projects/qt5/qtwebkit/Source/WTF/wtf/Deque.h:37,
                 from 
/home/milian/projects/qt5/qtwebkit/Source/WebKit2/Platform/CoreIPC/ArgumentDecoder.h:31,
                 from 
/home/milian/projects/qt5/qtwebkit/Source/WebKit2/Platform/CoreIPC/Attachment.cpp:29:
/home/milian/bbndk-2.0.1/target/qnx6/usr/include/cpp/xlocinfo: In function 
'int std::_Tolower(int, const std::_Ctypevec*)':
/home/milian/bbndk-2.0.1/target/qnx6/usr/include/cpp/xlocinfo:173: error: 
'tolower_WTF_Please_use_ASCIICType_instead_of_ctype_see_comment_in_ASCIICType_h' 
is not a member of 'std'
~~~~~~~~~~~~~~~~

-- 
Milian Wolff | milian.wolff at kdab.com | Software Engineer
KDAB (Deutschland) GmbH&Co KG, a KDAB Group company
Tel. Germany +49-30-521325470, Sweden (HQ) +46-563-540090
KDAB - Qt Experts - Platform-independent software solutions
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20120608/6e88c58c/attachment.bin>