[webkit-dev] Renaming DumpRenderTree to WebKitTestRunner or merging those two
rniwa at webkit.org
Sun Jun 3 17:05:47 PDT 2012
On Sun, Jun 3, 2012 at 3:55 PM, Maciej Stachowiak <mjs at apple.com> wrote:
> I am on vacation so I won't be able to review your patch in detail, but
> from your description it sounds less appealing to me than the WKTR
> approach. It seems like bad layering to me to define the IDL interface in
> WebCore for something actually implemented completely outside of WebCore.
While you're right that it's somewhat of a layer violation to define the
IDL for layoutTestController, WebCoreTestSupport appears to be the most
logical place to share files between DumpRenderTree and WebKitTestRunner at
the moment unless we're going to create another project/library in Tools.
It also seems better to use the public interface to the JS engine rather
> than the internal interface, even though this requires additional codegen
> back ends (one of which is already written). But, I may be missing
> advantages to your approach, since I only gave it a quick glance.
My intention is to contain all interactions with the JS engine within
WebCoreTestSupport so that you'd never see JSStringRef, JSContextRef,
etc... (or their V8 equivalents) in LayoutTestController code.
Now, we wouldn't have this problem if we were merging DumpRenderTree into
WebKitTestRunner, but that appears to be unrealistic at the moment as far
I've read the code.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the webkit-dev