[webkit-dev] layout tests: how are some compared against image, and others only text?

[James Robinson]

On Wed, Jan 4, 2012 at 3:39 PM, Elliot Poger <epoger at chromium.org> wrote:

> What is it that causes some tests to require baseline images (and not text
> files) for comparison, while others require text and not image baselines?
>
> (I know that I can specifically SKIP comparison against IMAGE and/or TEXT
> using test_expectations.txt... but even without the use of
> test_expectations, I believe that some tests are compared against only text
> or only image.)
>
> As an example, I see that this test has only image baselines and no text
> baselines:
>
> $ ls LayoutTests/platform/*/fast/canvas/canvas-text-baseline*.png | wc -l
> 10
> $ ls LayoutTests/platform/*/fast/canvas/canvas-text-baseline*.txt | wc -l
> ls: cannot access
> LayoutTests/platform/*/fast/canvas/canvas-text-baseline*.txt: No such file
> or directory
>
0
>

Wrong, you've missed some:

 $ find LayoutTests/ -name canvas-text-baseline*
LayoutTests/platform/chromium-linux/fast/canvas/canvas-text-baseline-expected.png
LayoutTests/platform/gtk/fast/canvas/canvas-text-baseline-expected.png
LayoutTests/platform/qt/fast/canvas/canvas-text-baseline-expected.png
LayoutTests/platform/efl/fast/canvas/canvas-text-baseline-expected.png
LayoutTests/platform/chromium-win/fast/canvas/canvas-text-baseline-expected.png
LayoutTests/platform/chromium-gpu-linux/fast/canvas/canvas-text-baseline-expected.png
LayoutTests/platform/chromium-gpu-win/fast/canvas/canvas-text-baseline-expected.png
LayoutTests/platform/mac/fast/canvas/canvas-text-baseline-expected.png
LayoutTests/fast/canvas/canvas-text-baseline.html
LayoutTests/fast/canvas/canvas-text-baseline-expected.txt <-------- this
one applies


> while this test has only text baselines and no image baselines:
>
> $ ls LayoutTests/platform/*/fast/canvas/canvas-lineWidth*.png | wc -l
> ls: cannot access
> LayoutTests/platform/*/fast/canvas/canvas-lineWidth*.png: No such file or
> directory
> 0
> $ ls LayoutTests/platform/*/fast/canvas/canvas-lineWidth*.txt | wc -l
> 5
>

This test calls layoutTestController.dumpAsText() (in js-test-pre.js), so
there's no .png.

- James

>
> Is there something inherent in each test that indicates whether its
> results will be compared against image and/or text baselines?  Or is it
> simply a matter of what baseline files are found to compare against?
>
>
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20120104/393de02e/attachment.html>