[webkit-dev] WebKit modularization

Adam Barth abarth at webkit.org
Mon Feb 27 11:54:34 PST 2012

2012/2/27 Adam Barth <abarth at webkit.org>:
> 2012/2/27 Alexey Proskuryakov <ap at webkit.org>:
>> 24.02.2012, в 10:00, Adam Barth написал(а):
>>> I'm happy to re-check them for license errors.  If you can send me a
>>> list of the license errors you've noticed, I'll make sure they get
>>> addressed.
>> For the record, I sent comments via private e-mail, and Adam refused to follow up on this promise (there was a partial patch he made before receiving my e-mail, but that was all). A number the files still have license errors, mostly copyright assigned to Google on code that was written by others. I did not send a specific list of things to fix, however I don't think that it's too much to ask one to go through patches in a specific area they reviewed recently.
>> I'm deeply concerned about the way this refactoring is implemented - it doesn't have much of a meaningful purpose overall, and patches are reviewed carelessly.
> Huh?  I'm sorry, I thought I addressed all the issues you spotted.
> Are there more I missed?  I certainly don't have any wish (or
> motivation) to mess up the copyright blocks.

For the record, I re-checked the three issues Alexey pointed me to in
private email.  Two have been fixed and one was in a patch that was
never reviewed or landed.


More information about the webkit-dev mailing list