[webkit-dev] Should we move methods from layoutTestController/etc... to internals?

[Ryosuke Niwa]

I'd prefer getting rid of the entire interface when possible. We're
obviously removing layoutTestController, textInputController, etc... at the
moment though.

- Ryosuke

On Tue, Feb 21, 2012 at 12:59 PM, Maciej Stachowiak <mjs at apple.com> wrote:

>
> Would you move the interface objects or just the methods?
>
>  - Maciej
>
> On Feb 21, 2012, at 12:15 PM, Ryosuke Niwa wrote:
>
> Hi,
>
> It appears to me window.internals is a superior solution to expose
> cross-platform features to our test harness compared to other interfaces
> implemented in DumpRenderTree and WebKitTestRunner such as
> layoutTestController and friends.
>
> Should we try to move methods of layoutTestController and friends that
> expose WebCore-level features to internals? Moving methods to internals
> would reduce DRT/WTR's code size, and lower the entry barrier for new ports.
>
> For example, PlainTextController seems to exist only to expose
> Range::text(). But this function can be exposed via internals for testing
> purposes instead since it doesn't depend on any port-specific code.
>
> Of course, there will be interfaces that rely on WebKit-layer code (e.g.
> TextInputController) we shouldn't be moving.
>
> Best,
> Ryosuke Niwa
> Software Engineer
> Google Inc.
>
>
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20120221/3075d4ef/attachment.html>