[webkit-dev] Please avoid rolling out patches speculatively and reland them ASAP if you had to

Peter Kasting pkasting at chromium.org
Tue Dec 11 14:17:56 PST 2012


On Tue, Dec 11, 2012 at 2:14 PM, Oliver Hunt <oliver at apple.com> wrote:

> I don't understand why anyone is _speculatively_ rolling out patches.
>
> You should only be rolling it out if you _know_ the patch is bad.
>

Sometimes something bad happens to the tree, the sheriff doesn't know which
patch is responsible, and the change authors are not present to ask for
help.  In a case like this the sheriff has to either do speculative
rollouts or leave the tree broken.

Ideally, of course, change authors are around when something like this
happens.  But maybe the bustage doesn't happen until much later, due to
some subtle/latent issue, or maybe the change author is in fact
irresponsible.

PK
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20121211/3f4369b1/attachment.html>


More information about the webkit-dev mailing list