[webkit-dev] Please avoid rolling out patches speculatively and reland them ASAP if you had to

[Emil A Eklund]

On Tue, Dec 11, 2012 at 1:14 PM, Peter Kasting <pkasting at chromium.org> wrote:
> On Tue, Dec 11, 2012 at 1:11 PM, Emil A Eklund <eae at chromium.org> wrote:
>>
>> > That said, if your strong reason turned out to be incorrect, you should
>> > recommit the patch, no?
>>
>> That seems like a bad idea, someone that understands the patch should
>> recommit it. Ideally the original author.
>
>
> I don't understand your logic.  A patch landed, the sheriff thinks maybe it
> was bad and rolls it out, then it turns out it was a red herring.  Why is it
> not now the sheriff's responsibility to re-land?  After all, the patch was
> landed originally by people who understood it and hasn't been seen to cause
> any problems.

There might very well have been other changes that conflicts with it.
If it applies cleanly then I agree with you that whoever rolled it out
should reland it. If there are conflicts or if it requires merging in
any way though I'd argue that the original author needs to get
involved.