[webkit-dev] Please avoid rolling out patches speculatively and reland them ASAP if you had to

Peter Kasting pkasting at chromium.org
Tue Dec 11 13:14:20 PST 2012

On Tue, Dec 11, 2012 at 1:11 PM, Emil A Eklund <eae at chromium.org> wrote:

> > That said, if your strong reason turned out to be incorrect, you should
> recommit the patch, no?
> That seems like a bad idea, someone that understands the patch should
> recommit it. Ideally the original author.

I don't understand your logic.  A patch landed, the sheriff thinks maybe it
was bad and rolls it out, then it turns out it was a red herring.  Why is
it not now the sheriff's responsibility to re-land?  After all, the patch
was landed originally by people who understood it and hasn't been seen to
cause any problems.

On the occasions when I've had to roll-out to diagnose an issue, I've
always re-landed patches that it turns out weren't broken.  Not doing this
seems not only extremely rude but actively dangerous to the health of the
tree, since other changes may now be landed or near-landing that depend on
this change.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20121211/7115eb4f/attachment.html>

More information about the webkit-dev mailing list