[webkit-dev] Implementing CSS3 Paged Media Margin Boxes

Milian Wolff milian.wolff at kdab.com
Fri Apr 27 07:22:33 PDT 2012

Hey all,

I would like to work on the CSS3 Paged Media support, esp. the margin boxes. 
I'm studying the code for some time now and would welcome it if someone could 
assist me in figuring out what needs to be done...

First up, I think I should tackle the missing support in the parser, i.e. 
solving the FIXME in CSSParser::createMarginAtRule. I found that 
CSSFontFaceRule looks similar and could write some code based on that. A few 
questions arise now:

a) For the unit tests (probably not only there) I need to have a special 
margin-at CSSRule for cssText(). I'll probably be able to copy most of the 
stuff again, but where in the build system do I have to add these new files?

b) What CSSRule::Type should the above have? WEBKIT_MARGINAT_RULE at the end 
(hence value 11)?. I could not find an official IDL proposal that includes the 
margin at rules.

c) These margin-at rules can only occur inside a page rule, and I need to 
access them from somewhere - what is the suggested path to take here? create 
StyleRulePage::setMarginRules or similar? Or reuse stuff from StyleRuleBlock?

d) When I have some partial patch ready, where could I get input? Should I 
attach it to a bug report (I've opened 
https://bugs.webkit.org/show_bug.cgi?id=85062 for that purpose)

f) I see that there are files like JSCSSFontFaceRuleCustom.cpp - what do I 
need to do there to get the new MediaAtRule accessible from JavaScript?

Milian Wolff | milian.wolff at kdab.com | Software Engineer
KDAB (Deutschland) GmbH&Co KG, a KDAB Group company
Tel. Germany +49-30-521325470, Sweden (HQ) +46-563-540090
KDAB - Qt Experts - Platform-independent software solutions
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20120427/a097df60/attachment.bin>

More information about the webkit-dev mailing list