[webkit-dev] run-webkit-tests --pixel-tests and text-based tests

[Milian Wolff]

On Wednesday 18 April 2012 14:03:51 Dirk Pranke wrote:
> On Wed, Apr 18, 2012 at 10:40 AM, Milian Wolff <milian.wolff at kdab.com> 
wrote:
> > Hey all,
> > 
> > I'm working on isPrinting() support for the Qt port and noticed that if I
> > do something like this:
> > 
> > ./Tools/Scripts/run-webkit-tests -p LayoutTests/printing/
> > 
> > Then I get lots of "failures" due to missing image baselines for tests
> > like
> > printing/page-rule-css-text-expected.html.
> > 
> > Thing is: Tests like the above are not pixel-based. So how do other test
> > suites detect this?
> 
> You should only get complaints about missing image baselines if DRT
> thinks that the test should generate a PNG. The way DRT detects that
> is if --pixel-tests is passed on the command line and
> layoutTestController.dumpAsText() is *not* called (i.e., PNGs are the
> default).

Ah, thanks!

> Assuming there's a typo in your email, and you meant to refer to
> printing/page-rule-css-text.html (not -expected.html, which is the
> convention we use for reference tests), that test is supposed to be a
> text-only test.

Yep, was a typo.

> *However*, it's possible that there's a bug occuring when you run the
> test such that dumpAsText() is not actually getting invoked. In that
> case, you'll get the MISSING baselines warning.
> 
> There is not a good way to fix this (i.e., to not get these false
> warnings) that I'm aware of.
> 
> I hope that's helpful,

Yes, very much. I've created a patch that fixes Qt's DRT according to your 
comments, i.e. to prevent pixel-dumps when dumpAsText was called.

See: https://bugs.webkit.org/show_bug.cgi?id=84327

Cheers
-- 
Milian Wolff | milian.wolff at kdab.com | Software Engineer
KDAB (Deutschland) GmbH&Co KG, a KDAB Group company
Tel. Germany +49-30-521325470, Sweden (HQ) +46-563-540090
KDAB - Qt Experts - Platform-independent software solutions
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20120419/a9847d62/attachment.bin>