[webkit-dev] run-webkit-tests --pixel-tests and text-based tests

[Dirk Pranke]

On Wed, Apr 18, 2012 at 10:40 AM, Milian Wolff <milian.wolff at kdab.com> wrote:
> Hey all,
>
> I'm working on isPrinting() support for the Qt port and noticed that if I do
> something like this:
>
> ./Tools/Scripts/run-webkit-tests -p LayoutTests/printing/
>
> Then I get lots of "failures" due to missing image baselines for tests like
> printing/page-rule-css-text-expected.html.
>
> Thing is: Tests like the above are not pixel-based. So how do other test
> suites detect this?
>

You should only get complaints about missing image baselines if DRT
thinks that the test should generate a PNG. The way DRT detects that
is if --pixel-tests is passed on the command line and
layoutTestController.dumpAsText() is *not* called (i.e., PNGs are the
default).

Assuming there's a typo in your email, and you meant to refer to
printing/page-rule-css-text.html (not -expected.html, which is the
convention we use for reference tests), that test is supposed to be a
text-only test.

*However*, it's possible that there's a bug occuring when you run the
test such that dumpAsText() is not actually getting invoked. In that
case, you'll get the MISSING baselines warning.

There is not a good way to fix this (i.e., to not get these false
warnings) that I'm aware of.

I hope that's helpful,

-- Dirk