[webkit-dev] Enable REQUEST_ANIMATION_FRAME on all ports? (was Re: ENABLE flag cleanup strawman proposal)

[Adam Barth]

On Sat, Sep 24, 2011 at 11:21 PM, Adam Barth <abarth at webkit.org> wrote:
> On Thu, Sep 15, 2011 at 11:06 AM, Adam Barth <abarth at webkit.org> wrote:
>> On Wed, Sep 14, 2011 at 11:06 PM, Darin Fisher <darin at chromium.org> wrote:
>>> What about ENABLE(REQUEST_ANIMATION_FRAME)?
>>
>> That might make sense to always enable.  It seems to be very popular.
>
> REQUEST_ANIMATION_FRAME appears not to be enabled for GTK, Qt, or
> AppleWin.  Is there port-specific work that needs to be done to enable
> the feature for those ports?

Looking a the code briefly, it appears that the
USE(REQUEST_ANIMATION_FRAME_TIMER) flavor doesn't require
port-specific work, but the non-timer version had a dependency on
ChromeClient::scheduleAnimation().

I'll try to cook up a patch that enables REQUEST_ANIMATION_FRAME
everywhere and uses USE(REQUEST_ANIMATION_FRAME_TIMER) on ports
without ChromeClient::scheduleAnimation().

Adam