[webkit-dev] Committing EFL baselines

Ryosuke Niwa rniwa at webkit.org
Mon Sep 12 15:15:33 PDT 2011


On Mon, Sep 12, 2011 at 2:50 PM, Leandro Pereira <leandro at profusion.mobi>wrote:
>
> Most differences are because the EFL port doesn't change the viewport size
> because of the scrollbar: it is drawn on top of the content on the EFL port
> by default. So there is a little more room horizontally, and then text
> results are slightly different from GTK+'s (which uses the same font
> backends, for instance).
>
> In those tests that only draws colored rectangles, the render tree is
> pretty much the same as any other port's. However, in these tests, the pixel
> results are rendered with colors slightly different from the expected.
> Almost no difference to the naked eye. I suspect either some rounding
> problems inside Cairo, or wrong color profile.
>

Chromium port has made a significant effort into matching scrollbar/color
with Mac port to mitigate this issue. Maybe you can talk to one of our
friendly contributors and get some help in reducing the number of baselines
you need to check in.

I don't intend to claim that you're obligated to do this but if you check in
a lot of port-specific baselines, then you're very likely end up having to
rebaseline hundreds of tests each day to catch up with new changes landed in
trunk. This is a very tedious job and people from other ports spend a
significant engineering time into this.

- Ryosuke
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20110912/69ed6e43/attachment.html>


More information about the webkit-dev mailing list