ap at webkit.org
Thu Sep 8 19:21:45 PDT 2011
08.09.2011, в 12:25, Darin Adler написал(а):
> I find the bindings tests quite helpful. Because the perl script is so hard to read, it’s the changes in bindings script test results that I look at when reviewing changes to the bindings scripts. The fact that the results are checked in helps me review patches.
OK, then they are valuable indeed.
However, I still feel that there is a disconnect between the desired effect (provide a diff in a patch for review) and the implementation (tests that can pass or fail). This also puts the burden of maintaining the results on people who needn't care about them - for example, Oliver's patch clearly didn't need someone look over generated code changes.
I'm not sure what the better solution would be though. Perhaps a bot could provide a diff of DerivedSources for any patch that touches code generators, but I'm not volunteering to implement one :-)
- WBR, Alexey Proskuryakov
More information about the webkit-dev