[webkit-dev] Making PopupMenuClient testable

Johnny Ding jnd at google.com
Mon Oct 10 03:41:55 PDT 2011

在 2011年10月7日 下午11:56,Fady Samuel <fsamuel at chromium.org>写道:

> Hi all,
> I've just uploaded a patch https://bugs.webkit.org/show_bug.cgi?id=69631 that's
> intended to make PopupMenuClient testable.
> On certain Chromium platforms, the position of the <select> element's popup
> is incorrect if the page's scale factor is not 1.0.
> The fix to the problem is simple, see
> https://bugs.webkit.org/show_bug.cgi?id=66062 , but since popups are
> external to WebKit on most platforms, this is difficult to test.
> The patch above in bug 69631 attempts to addresses this, albeit in a less
> than ideal way. I'm not sure what's the best way to test this, but this is
> my stab at it.
Even if  the popup is external, the render dump (not text dump) still
contains layout information. You can write a layout test with page's scale
factor not 1.0, then generate the expectation results among WebKit ports.
 Do you think Is that enough for your test?

> I'd really appreciate any comments or suggestions you can provide on my
> patch for bug 69631.
> Thanks,
> Fady
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Best regards,
Johnny(Jianning) Ding | Software Engineer | jnd at google.com |
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20111010/877a1f70/attachment.html>

More information about the webkit-dev mailing list