[webkit-dev] Making PopupMenuClient testable

Fady Samuel fsamuel at chromium.org
Fri Oct 7 08:56:43 PDT 2011


Hi all,

I've just uploaded a patch https://bugs.webkit.org/show_bug.cgi?id=69631 that's
intended to make PopupMenuClient testable.

On certain Chromium platforms, the position of the <select> element's popup
is incorrect if the page's scale factor is not 1.0.

The fix to the problem is simple, see
https://bugs.webkit.org/show_bug.cgi?id=66062 , but since popups are
external to WebKit on most platforms, this is difficult to test.

The patch above in bug 69631 attempts to addresses this, albeit in a less
than ideal way. I'm not sure what's the best way to test this, but this is
my stab at it.

I'd really appreciate any comments or suggestions you can provide on my
patch for bug 69631.

Thanks,

Fady
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20111007/282fcad9/attachment.html>


More information about the webkit-dev mailing list