[webkit-dev] Cleaning up directories in WebCore

Dimitri Glazkov dglazkov at chromium.org
Fri Nov 18 08:46:33 PST 2011


I agree. My personal favorite is the moving out of the side-loaded
features. This looks like a great way to add clarity to what WebCore
really means.

:DG<

On Fri, Nov 18, 2011 at 2:19 AM, Eric Seidel <eric at webkit.org> wrote:
> SGTM.
>
> manual-tests is a no-brainer for sure.
>
> On Fri, Nov 18, 2011 at 1:51 AM, Adam Barth <abarth at webkit.org> wrote:
>> I've been looking for ways to improve the hackability of WebCore, and
>> one thing that's been bothering me is the organization of our files.
>> It seems like we're due for a bit of "fall cleaning" for directories.
>> We've talked about some of these ideas before, but I wanted to put
>> them all in one email so we can see the big picture.
>>
>> Below is a concrete proposal for moving some directories around.  In
>> this approach, we'll have a "Features" directory to contain logically
>> self-contained features, like WebAudio and MediaStream, that are part
>> of the engine but that aren't tightly coupled with the DOM, Layout, or
>> Rendering.  We'd also have a new "events" directory in "dom" to
>> contain the large number of event-related files that we've accreted.
>> The "history" directory would move into "page" (we could actually
>> merge these directories because history is so small).  Finally,
>> "manual-tests" and "platform" would move out of WebCore entirely.
>>
>> Features/  <-- New folder for (roughly) self-contained features
>>  notifications/
>>  storage/
>>  fileapi/
>>  webaudio/
>>  mediastream/
>>  workers/
>>  websockets/
>>  inspector/
>> manual-tests/  <-- Move outside of Source
>> dom/
>>  events/  <-- New folder for the 106 files that match dom/*Event*
>> page/
>>  history/  <-- Moved from top-level
>> platform/  <-- Move to Source/Platform
>>
>> The "html" and "page" directories also contain a bunch of unrelated
>> files (presumably because they're attractive locations for folks to
>> add files).  Once we do the directory moves above, I'll send out
>> another proposal for cleaning up those directories a bit.
>>
>> Please let me know if you have any thoughts.
>>
>> Thanks!
>> Adam
>> _______________________________________________
>> webkit-dev mailing list
>> webkit-dev at lists.webkit.org
>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>>
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>


More information about the webkit-dev mailing list