[webkit-dev] Windowless X based plugin and its support in WebKit and WebKit2 (GTK+ port)

[Aneesh Bhasin]

<Resending as I had mistakenly forgotten to send it to the mailing list>
Hi Carlos,

On Fri, May 6, 2011 at 7:00 PM, Carlos Garcia Campos <cgarcia at igalia.com> wrote:
> El Fri, 6 May 2011 17:13:17 +0530
> Aneesh Bhasin <contact.aneesh at gmail.com> escribió:
>> Hi All,
>
> Hi,
>
>> I have been trying to understand the WebKit2 source and hopefully
>> start contributing small missing functionality to start with. Towards
>> this goal, I have implemented a small browser that can open multiple
>> tabs based on WebKit2 C API. I am currently using the GTK+ port from
>> the master branch of WebKit's git repo for this.
>>
>> As I understand, as of now plugins are not working in WebKit2/GTK+. To
>> understand the same and start contributing (if possible), I plan to
>> use a basic windowless plugin for understanding/debugging. However, my
>> problem is that when I open a test HTML page that has this plugin, it
>> opens fine in Firefox, and somewhat okay in Chrome (the position is
>> shifted), but when I open the same using GtkLauncher or midori, both
>> fail to show the plugin area - although I could see that the plugin's
>> NPP functions are receiving the calls and the plugin's event handler
>> is also fired with event type GraphicsExpose - but nothing is drawn in
>> plugin area. (The plugin should draw two empty squares with green
>> boundary on a black background.). It will be pointless to use this for
>> testing/understanding WebKit2 unless this works fine on WebKit.
>
> Do you mean the plugin doesn't work in webkit1 either? I'm not sure if
> you are talking about webkit1 or webkit2 here.
>
>> I have tried running this both on a recent commit on the master branch
>> as well as on WebKit/GTK+ version 1.4.0. The plugin code is as
>> attached below.
>>
>> Could someone please have a look and let me know if there is something
>> in the plugin that is wrong, or is there an issue in WebKit/GTK+ port
>> with respect to window-less plugins ? I tried looking at bugzilla but
>> could not find any relevant bugs...
>
> For WebKit2 see bugs:
>
> https://bugs.webkit.org/show_bug.cgi?id=60366
> https://bugs.webkit.org/show_bug.cgi?id=60368
>
> Both are needed to make plugins work. You can test it with MiniBrowser.

I have applied the patches attached with the two bugs you mentioned
above, and using them I am able to open a web page having the simple
windowless plugin (that I had attached earlier) in
WebKit2/MiniBrowser. Thanks again for the pointer...!

However, I still don't understand why the same plugin is not showing
in WebKit1 based GtkLauncher.

Regards,
Aneesh