[webkit-dev] Adding ENABLE_GESTURE_MANAGER

Robert Kroeger rjkroege at chromium.org
Mon May 9 12:09:09 PDT 2011


On Mon, May 9, 2011 at 3:03 PM, Ryosuke Niwa <rniwa at webkit.org> wrote:
> On Mon, May 9, 2011 at 11:32 AM, Robert Kroeger <rjkroege at chromium.org>
> wrote:
>> As suggested by Eric Seidel's email from earlier today, I thought it
>> would be proper to let you know that I am in the process of adding a
>> touch gesture recognition feature to the Chromium port of WebKit. The
>> first part of this feature is
>> https://bugs.webkit.org/show_bug.cgi?id=49345. This patch adds a hook
>> to WebCore to pass touch events to an optional platform-specific
>> gesture recognition engine. The code is turned off by default except
>> in the Chromium port where it is enabled with ENABLE_GESTURE_MANAGER.
> Can't we just reuse ENABLE(TOUCH_EVENTS) and implement some client
> interface?

The reviewers suggested that a new ENABLE_ was desirable. I would tend
to agree because several important platforms (iOS, Android) enable
TOUCH_EVENTS but do gesture recognition in a quite different fashion.
I'd be happy to strip the extra ENABLE_ in a future CL when the chrome
gesture recognizer has been shown to be working well.

> - Rysouke


More information about the webkit-dev mailing list