[webkit-dev] A tip for committers

[Dan Bates]

On Thu, 3 Mar 2011 12:47:56 -0800, Adam Barth <abarth at webkit.org> wrote:
> Dan Bates has done a bunch of great work teaching svn-apply about SVN
> properties.  I know svn-apply understands the executable bit, but I'm
> unsure about the other properties.
> 

svn-{apply, unapply} only respect the executable bit at this time because
we wanted to ensure feature parity for both Git and SVN patches. That is,
we wanted svn-apply to be able to apply a Git patch that includes file
mode
info to an SVN repository and also the converse operation (SVN patch
applied to a Git repository). Additional properties can be supported.

Clearly it would be beneficial if we could maintain some kind of Git/SVN
property parity and/or inform the user/stop the commit-queue when
disagreement occurs.

Additional remarks:

The SVN property parsing machinery is sufficiently general to support
additional SVN properties. See our unit tests in
Tools/Scripts/webkitperl/VCSUtils_unittest for more details. In
particular,
see the test cases in parseSvnProperty.pl:
<http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl?rev=74301>.

Dan