[webkit-dev] A tip for committers

Adam Barth abarth at webkit.org
Thu Mar 3 12:47:56 PST 2011


Dan Bates has done a bunch of great work teaching svn-apply about SVN
properties.  I know svn-apply understands the executable bit, but I'm
unsure about the other properties.

Adam


On Thu, Mar 3, 2011 at 9:32 AM, Alexey Proskuryakov <ap at webkit.org> wrote:
>
> 03.03.2011, в 08:42, Adam Roben написал(а):
>
>> Subversion properties aren't captured in patches, so the style bot is too early in the process. We could add a pre-commit hook to check for the right properties, though.
>
>
> I've always seen subversion properties in my and others' patches, see e.g. <https://bugs.webkit.org/attachment.cgi?id=56906&action=review>. There's also often an svn-executable bit seen in patches, too. I'm not sure if svn-apply preserves properties, though.
>
> See also: <https://bugs.webkit.org/show_bug.cgi?id=23631> "WebKit needs a script to maintain proper SVN properties".
>
> - WBR, Alexey Proskuryakov
>
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>


More information about the webkit-dev mailing list